search

redhat-developer / alizer

⛔️ DEPRECATED - Application analyzer toolkit, use https://github.com/devfile/alizer instead
Apache License 2.0
12 stars 17 forks source link

Add min-version and max-version CLI arguments #226

Closed thepetk closed 1 year ago

thepetk commented 1 year ago

Which area/kind this issue is related to?

/area cli

Issue Description

As part of the proposal for #159 two CLI arguments have to be introduced. First the min-version and then the max-version args. As stated in the proposal the min version represents the minimum version of the matched devfile and the max version the maximum. In case the minimum version is greater than the maximum an error should be raised.

Target Date: 30 June 2023

thepetk commented 1 year ago

I've created the #234 but I'm also having some issues with fetching the devfiles from v2index. When we are using x.x.x version or 1.x version it returns 500.

thepetk commented 1 year ago

I've created an issue in the devfile-api (https://github.com/devfile/api/issues/1128) in order fix the above behavior. I would say that the current issue is blocked.

Regarding alizer's onboarding, I would say maybe we could consider excluding this task from https://github.com/redhat-developer/alizer/issues/166 as we have now transformed #159 into an epic. Maybe we can onboard alizer having merged the 2 of the 4 tasks ( #https://github.com/redhat-developer/alizer/issues/153 and #225 - both under review)

cc @elsony @mike-hoang

thepetk commented 1 year ago

I've put the blocked label for this and updated the blocking issue https://github.com/devfile/api/issues/1128

thepetk commented 1 year ago

Removed blocked from the issue as devfile/api#1128 is closed

thepetk commented 1 year ago

I've updated the #234 and is now under review :)

thepetk commented 1 year ago

closing in favor of https://github.com/devfile/api/issues/1171