As part of #159 we are introducing the two first cli args in order to support specific versions of devfiles. Those two are min-version and max-version.
If this argument is passed in the cli we are updating the URL for the download of the devfiles from the registry (following this link). This way we are filtering the list of devfiles we are getting from the registry.
Some edge cases:
If min-version is higher than max-version an error is raised.
If min-version and/or max-version is lower than 2.0.0 (the lowest accepted version from the registry API) then an error is raised.
A slight addition is also made to the model.DevfileType in order to include information for versions. For backwards compatibility reasons we are no longer using SelectDevFilesFromRegistry but MatchDevfiles.
A new model.DevfileFilter is created in order to include all future filters inside the devfile API and ensure scalability.
Updates are made inside the documentation of the project to include all changes introduced and test cases regarding the URL update are added.
Which issue(s) does this PR fix
fixes #226
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
[ ] Unit/Functional tests
[x] Documentation
How to test changes / Special notes to the reviewer
What does this PR do?
As part of #159 we are introducing the two first cli args in order to support specific versions of devfiles. Those two are
min-version
andmax-version
.If this argument is passed in the cli we are updating the URL for the download of the devfiles from the registry (following this link). This way we are filtering the list of devfiles we are getting from the registry.
Some edge cases:
min-version
is higher thanmax-version
anerror
is raised.min-version
and/ormax-version
is lower than2.0.0
(the lowest accepted version from the registry API) then an error is raised.A slight addition is also made to the
model.DevfileType
in order to include information for versions. For backwards compatibility reasons we are no longer usingSelectDevFilesFromRegistry
butMatchDevfiles
.A new
model.DevfileFilter
is created in order to include all future filters inside the devfile API and ensure scalability.Updates are made inside the documentation of the project to include all changes introduced and test cases regarding the URL update are added.
Which issue(s) does this PR fix
fixes #226
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
[ ] Unit/Functional tests
[x] Documentation
How to test changes / Special notes to the reviewer