redhat-developer / alizer

⛔️ DEPRECATED - Application analyzer toolkit, use https://github.com/devfile/alizer instead
Apache License 2.0
12 stars 17 forks source link

Add detection of wildfly-jar-maven-plugin #243

Closed thepetk closed 1 year ago

thepetk commented 1 year ago

Which area this feature is related to?

/area cli /area library /area documentation

Which functionality do you think we should add?

Why is this needed? Is your feature request related to a problem?

In order to be able to separate cases between the wildly bootable jar devfile and the wildly devfile it would be helpful if we add a detector for wildfly bootable jar.

Describe the solution you'd like

We can base the solution on the implementation for wildfly_detector, introducing the wildfly_jar_detector. As a result, upon WildFlyJarDetecor we will have:

func (o WildFlyJarDetector) DoFrameworkDetection(language *model.Language, config string) {
    if hasFwk, _ := hasFramework(config, "org.wildfly.plugins", "wildfly-jar-maven-plugin"); hasFwk {
        language.Frameworks = append(language.Frameworks, "WildFly Bootable Jar")
    }
}

Also, we will have to update the current documentation and add this as "framework" of java applications.

Additional context

An example application using this plugin is https://github.com/wildfly-extras/wildfly-jar-maven-plugin/blob/main/examples The content inside pom.xml is:

<build>
        <pluginManagement>
            <plugins>
                <plugin>
                    <groupId>org.wildfly.plugins</groupId>
                    <artifactId>wildfly-jar-maven-plugin</artifactId>
                    <version>${version.bootable.jar}</version>
                </plugin>
        </pluginManagement>
</build>
thepetk commented 1 year ago

closing in favor of https://github.com/devfile/api/issues/1161