search

redhat-developer / app-services-cli

Command Line Interface for RHOAS
https://redhat-developer.github.io/app-services-website/
Apache License 2.0
41 stars 72 forks source link

Kas-installer: size parameter seemingly ignored #1594

Open k-wall opened 2 years ago

k-wall commented 2 years ago

Testing the 0.44 alpha, using kas-installler (fleet-manager registered_users_per_organisation config configured with max_allowed_instances 2).

rhoas kafka create --bypass-checks --provider aws  --name penguin --size=x2

is accepted, but an x1 results.

{
  "browser_url": "http://localhost:8080/cahjsobprem07ts5qlog/dashboard",
  "cloud_provider": "aws",
  "created_at": "2022-06-10T12:51:45.301121744Z",
  "egress_throughput_per_sec": "100Mi",
  "href": "/api/kafkas_mgmt/v1/kafkas/cahjsobprem07ts5qlog",
  "id": "cahjsobprem07ts5qlog",
  "ingress_throughput_per_sec": "50Mi",
  "instance_type": "standard",
  "instance_type_name": "Standard",
  "kafka_storage_size": "1000Gi",
  "kind": "Kafka",
  "max_connection_attempts_per_sec": 100,
  "max_data_retention_period": "P14D",
  "max_partitions": 1500,
  "multi_az": true,
  "name": "penguin",
  "owner": "kwall_mk-bin-packing",
  "reauthentication_enabled": true,
  "region": "us-east-1",
  "size_id": "x1",
  "status": "accepted",
  "total_max_connections": 3000,
  "updated_at": "2022-06-10T12:51:45.301121744Z"
}

Originally posted by @k-wall in https://github.com/redhat-developer/app-services-cli/issues/1592#issuecomment-1152342236

wtrocki commented 2 years ago

@k-wall - I'm really sorry for issues that you have been experiencing. I think generally we need to introduce kas-installer as valid target for the CLI and UI and pick right architecture to avoid billing. Initially that wasn't a bit problem in CLI as it was only about terms and conditions. Now we would have dozens of flags for billing, sizes that strongly depend on AMS.

I will investigate why this is happening and make fix asap

wtrocki commented 2 years ago

Done quick check and I think this is quite tricky to do as in backend we mix both instance type and size value. instance types cannot be passed by users thus we need AMS for it.

plan developer.x1 or standard.x2 is being sent to backend. So if we do not have AMS information about what type of instance we want:

We cannot really effectively send plan value to backend.

CC @pb82 - maybe we could chat about this next week.

wtrocki commented 2 years ago

I think we need discussion in the team how we can support kas-installer without ams. First idea in mind would be to have number of extra flags only for kas-installer that will provide missing ams info