redhat-developer / app-services-cli

Command Line Interface for RHOAS
https://redhat-developer.github.io/app-services-website/
Apache License 2.0
42 stars 72 forks source link

Supporting gitops #1746

Closed wtrocki closed 2 years ago

wtrocki commented 2 years ago

Motivation

Enable users to fetch state for their organization and personal account required for kafka creation. This approach enables granular set of commands that can be useful for users to get information about where kafka is deployed and how they are billed by creating kafka.

Supported commands

Fetching cloud providers and regions

[wtrocki@graphapi app-services-cli (supporting-gitops)]$ rhoas kafka providers 
  CLOUD PROVIDER   REGION     
 ---------------- ----------- 
  aws              eu-west-1  
  aws              us-east-1  

Fetching billing types

This command fetching billing information - We need to extend this by including plans etc. Depends on @rkpattnaik780 investigation on how we can represent all of that in gitops setup.

[wtrocki@graphapi app-services-cli (supporting-gitops ✗)]$ rhoas kafka billing
  BILLING    
 ----------- 
  developer  
wtrocki commented 2 years ago

@rkpattnaik780 feel free to add your results of investigation if needed.

rkpattnaik780 commented 2 years ago

Output of rhoas kafka providers:

  CLOUD PROVIDER (6)    REGION      SUPPORTED PLAN  
 --------------------- ----------- ---------------- 
  aws                   eu-west-1   developer.x1    
  aws                   eu-west-1   standard.x1     
  aws                   eu-west-1   standard.x2     
  aws                   us-east-1   developer.x1    
  aws                   us-east-1   standard.x1     
  aws                   us-east-1   standard.x2 

Output of rhoas kafka billing:

BILLING       MARKETPLACE ACCOUNT ID   MARKETPLACE PROVIDER  
 ------------- ------------------------ ---------------------- 
  marketplace   568056954830             aws                   
  standard                                               
dimakis commented 2 years ago

I was just checking this out to check the response. This is great, I wonder if we could do with more information? like some more of an explainer as to what those options are? or at least pointing to docs somewhere that does explain what we mean by these terms, standard marketplace etc.

IMO even a small reminder to the user would suffice here. Trying to make it as easy as possible.

thats just my suggestion, what is here LGTM

wtrocki commented 2 years ago

Awesome work!

Only developer instances are available

Would that be harder for people who just want to copy paste values? IMHO Single value is simpler to parse by human than text :D

or at least pointing to docs somewhere that does explain what we mean by these terms, standard marketplace etc.

Documentation for this is hard to come by. We can flag it to be documented in some way or use that as opportunity to build documentation for those terms.

rkpattnaik780 commented 2 years ago

Would that be harder for people who just want to copy paste values? IMHO Single value is simpler to parse by human than text :D

Earlier implementation printed "developer" as the billing type, which should not be the case, the developer instances have billing types "marketplace" and "standard". But again, those can be rejected by API.

wtrocki commented 2 years ago

Knowing that is better to leave it this way