redhat-developer / app-services-cli

Command Line Interface for RHOAS
https://redhat-developer.github.io/app-services-website/
Apache License 2.0
42 stars 72 forks source link

feat(kafka create): enable creating long-lived trial instances #1800

Closed rkpattnaik780 closed 1 year ago

rkpattnaik780 commented 1 year ago

Add additional billing model eval to create long lived trial instances.

Verification Steps

  1. Create a local binary of the CLI:
    make binary
  2. Login to an org having quotas for long lived trial instances
    rhoas login --api-gateway staging
  3. Run kafka create command setting eval as billing model
    ./rhoas kafka create --name test-instance --billing-model eval --dry-run -v
  4. The logs should show that the selected quota object with name "eval".
  5. Request body should have billing model "eval".

Type of change

ziccardi commented 1 year ago

If you specify the EVAL billing model, KFM requires that you specify the instance type you want to create (as of today, standard is the only accepted value).

rkpattnaik780 commented 1 year ago

Hello @ziccardi I have addressed your comments and off-thread discussions. Just wanted to confirm if the instance-type here is set in Plan along with size or will it be a new parameter in the Kafka create payload?

ziccardi commented 1 year ago

@Hi @rkpattnaik780 ! After yesterday's chat, I looked back into the code and made some tests. I was wrong: specifying the instance type/plan is not mandatory. You can specify only the billing model. Sorry for the confusion.