search

redhat-developer / app-services-guides

End User Guides for popular programming languages and tools
Apache License 2.0
24 stars 63 forks source link

Add labels to RHODS YAML files #634

Closed vconzola closed 1 year ago

vconzola commented 1 year ago

Fixes RHODS piece of MGDSTRM-7351

vconzola commented 1 year ago

@tiffanynolan @fmcdonal @AedinC @MelissaFlinn Please review.

fmcdonal commented 1 year ago

also Aron responsible for RHODA checks were generated after er created his PR: https://github.com/redhat-developer/app-services-guides/pull/633

fmcdonal commented 1 year ago

@vconzola as explained in Aron PR https://issues.redhat.com/browse/DBAAS-1187 1 check failed because the template of the quickstart schema which allows you to add the labels field under metadatawas changed and has not been merged until release. After that PR gets merged, you can rebase/merge the latest code on the main branch to your PR and force-push again. Then you are likely to see the test passes.

fmcdonal commented 1 year ago

I spotted that the Approve and run button is now showing. I clicked it and it now generated the checks with 1 failing as suspected due to the schema file being updated.

vconzola commented 1 year ago

Juntao walked me thru the whole process. What are "Checks"? He didn't say anything about them.

Vince Conzola

Red Hat https://www.redhat.com/

100 E. Davie Street

Raleigh, NC 27609

@.*** T: 919-716-5041 M: 919-459-7865 https://red.ht/sig

On Tue, Feb 7, 2023 at 6:49 AM fmcdonal @.***> wrote:

@.**** approved this pull request.

all look good to me but I still see no "Checks" triggered from generating the PR, could Juntao help?

— Reply to this email directly, view it on GitHub https://github.com/redhat-developer/app-services-guides/pull/634#pullrequestreview-1286946745, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFOEA6Z5QXD35RTUHSKRO2TWWIZFVANCNFSM6AAAAAAUTEHGCY . You are receiving this because you authored the thread.Message ID: @.*** com>

fmcdonal commented 1 year ago

@vconzola if you remember on our call I showed you the "Checks" tab beside "Files changed".

vconzola commented 1 year ago

@fmcdonal I remember where they are in GitHub, I'm just trying to understand what they mean and how they get generated. But it looks like they're in there now, so I'm not going to worry about it.