search

redhat-developer / app-services-sdk-js

RHOAS SDK for JavaScript and Typescript
https://redhat-developer.github.io/app-services-sdk-js
Apache License 2.0
3 stars 16 forks source link

feat: update smartevents to v2 #581

Closed dimakis closed 1 year ago

dimakis commented 1 year ago

Updating smartevents mgmr to use v2 of their openapi spec file

the v2 is already present in the repo

jackdelahunt commented 1 year ago

@dimakis

So we are upgrading the api in the SDK, are we planing this for the other SDKs?

dimakis commented 1 year ago

@dimakis

So we are upgrading the api in the SDK, are we planing this for the other SDKs?

in what regard is that? if the other APIs are bumping their version?

This is coming from a request I got to bump the SDK version for smartevents. They want the same package, just different version so this seems the most seamless way to do so

jackdelahunt commented 1 year ago

in what regard is that? if the other APIs are bumping their version?

Well if they want to. bumb the version of this dont we want our. sdks in sync shouldnt this also be applied to other SDKs. But maybe i am misunderstanding.

dimakis commented 1 year ago

in what regard is that? if the other APIs are bumping their version?

Well if they want to. bumb the version of this dont we want our. sdks in sync shouldnt this also be applied to other SDKs. But maybe i am misunderstanding.

sorry, you mean other languages? yes indeed we do that is correct. Thats what I was hoping to achieve by "assigning" this to you last week. I've never used the assign thing before though so not sure if you got it or not 😅

jackdelahunt commented 1 year ago

Oh I see that you okay no problem will merge this, should we not re-generate sdk in pr aswell?

dimakis commented 1 year ago

Oh I see that you okay no problem will merge this, should we not re-generate sdk in pr aswell?

I was going to do that manually. Usually this is automated as per https://github.com/redhat-developer/app-services-sdk-js/actions/runs/3490454820 I've not changed the Open API spec file like this before though so I was just going to do a manual regen of the SDKs before releasing just to make sure.