Create initial GVK - Githubissues

redhat-developer / argocd-terraform-controller

Argo CD Terraform Controller

26 stars 7 forks source link

Closed christianh814 closed 2 years ago

christianh814 commented 2 years ago

Create initial Group and Kind of terraforms.infra.argoproj.io with version of v1alpha1

Fixes #1

Signed-off-by: Christian Hernandez chernand@redhat.com

sabre1041 commented 2 years ago

@christianh814 is there a reason infras is included in the group name?

christianh814 commented 2 years ago

@christianh814 is there a reason infras is included in the group name?

Two reasons

I don't know how not to include the group in the operatorsdk command 😬
I didn't want to mention long term plans because I want to get this out fast and introduce scope creep. But I want to plan for future controllers Argo CD can call (e.g. ansible-runner)

I don't mind not using it and I don't want to introduce more questions about "future" design

sabre1041 commented 2 years ago

@christianh814

You can omit the inclusion of the group in the operator-sdk. Just dont pass the parameter
Using ApplicationSet as an example. It alway omitted the use of a subdomani

christianh814 commented 2 years ago

@sabre1041 Okay updated by c5ce91c has no group