search

redhat-developer / devconsole-operator

Enable a developer-focused view in OpenShift 4 web console
24 stars 28 forks source link

adding annotations #122

Closed tinakurian closed 5 years ago

tinakurian commented 5 years ago

Relates to: https://jira.coreos.com/browse/ODC-83 Require devconsole-api PR to me approved and merged first: https://github.com/redhat-developer/devconsole-api/pull/19

Adding annotations to custom resources.

To test: run component_controller_test.go tests.

baijum commented 5 years ago

/retest

tinakurian commented 5 years ago

/retest

Thanks @baijum! This won't pass until i can update the revision for devconsole-api. Will only be able to do that after this PR is merged: https://github.com/redhat-developer/devconsole-api/pull/19. However, the ci for devconsole-api is currently not working :-) so will need to fix that first.

tinakurian commented 5 years ago

Results from running component_controller_test.go:

image

akashshinde commented 5 years ago

/LGTM

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akashshinde, DhritiShikhar To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: tinakurian

If they are not already assigned, you can assign the PR to them by writing /assign @tinakurian in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/devconsole-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment