search

redhat-developer / devconsole-operator

Enable a developer-focused view in OpenShift 4 web console
24 stars 28 forks source link

Add Gitsource and GitsourceAnalysis e2e tests #166

Open akashshinde opened 5 years ago

akashshinde commented 5 years ago

This PR adds e2e tests for GitSource and GitSourceAnanlysis. To test this PR execute.

make test-e2e
Avni-Sharma commented 5 years ago

/test lint

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Avni-Sharma To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: sbose78

If they are not already assigned, you can assign the PR to them by writing /assign @sbose78 in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/devconsole-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Avni-Sharma commented 5 years ago

@akashshinde you might want to rebase. Under make/lint.mk the deadline has been changed from 10m to 30m. Maybe that's y the prow/lint is failing

baijum commented 5 years ago

/test e2e

baijum commented 5 years ago

The e2eutils.go file name suggests generic utility functions. Since the functions are waiting related, how about renaming it to wait.go?

baijum commented 5 years ago

@akashshinde Can you merge changes from upstream/master and run tests again.

I am wondering why the e2e test is failing!

akashshinde commented 5 years ago

@baijum I am going to merge upstream/master now, I am wondering that also since e2e tests are passing locally.

akashshinde commented 5 years ago

/test test

sbose78 commented 5 years ago

/retest

openshift-ci-robot commented 5 years ago

@akashshinde: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e 98bc76b01048b851d6edc7d5e7ec1ad14aead519 link /test e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).