search

redhat-developer / devconsole-operator

Enable a developer-focused view in OpenShift 4 web console
24 stars 28 forks source link

[WIP] Create Makefile target to build & bundle CSV file #178

Closed baijum closed 5 years ago

baijum commented 5 years ago

The CI configuration will be updated to receive this:

- from: operator-registry
  inputs:
    bin:
      paths:
      - destination_dir: .
        source_path: /go/src/github.com/redhat-developer/devconsole-operator/out/csv.tar.gz
  dockerfile_path: openshift-ci/Dockerfile.registry.build
  to: devconsole-operator-registry

The bin build will be modified like this:

binary_build_commands: make ci-build
openshift-ci-robot commented 5 years ago

@baijum: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/images 948ef74f800778efe38f3dcc54c75934edb5aee3 link /test images
ci/prow/e2e 948ef74f800778efe38f3dcc54c75934edb5aee3 link /test e2e
ci/prow/e2e-ci 948ef74f800778efe38f3dcc54c75934edb5aee3 link /test e2e-ci

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbose78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/devconsole-operator/blob/master/OWNERS)~~ [sbose78] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
baijum commented 5 years ago

/hold

baijum commented 5 years ago

This is innovative. Nice!

Thanks!

I preferred to go for an intermediate image approach which looks relatively better. https://github.com/redhat-developer/devconsole-operator/pull/179

Looks like OML integration test is passing: https://github.com/openshift/release/pull/3634