search

redhat-developer / devconsole-operator

Enable a developer-focused view in OpenShift 4 web console
24 stars 28 forks source link

WIP: Implement basic Go test for OperatorSource #185

Closed ldimaggi closed 5 years ago

ldimaggi commented 5 years ago

Followup to pull request: https://github.com/redhat-developer/devconsole-operator/pull/181

This pull request adds the test program needed to complete the work started in #181.

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: alexeykazakov

If they are not already assigned, you can assign the PR to them by writing /assign @alexeykazakov in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/devconsole-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 years ago

Hi @ldimaggi. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akashshinde commented 5 years ago

@ldimaggi Can we make use of client-go library instead of using oc commands directly ? and How about including this tests as part of e2e tests ? cc: @sbose78

sbose78 commented 5 years ago

and How about including this tests as part of e2e tests

@akashshinde , yes that should be the logical next step!

pratikjagrut commented 5 years ago

This test is added in PR 181 @ldimaggi you should close this PR being duplicate of PR181.

ldimaggi commented 5 years ago

Closing as duplicate of #181