Open akashshinde opened 5 years ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: sbose78
If they are not already assigned, you can assign the PR to them by writing /assign @sbose78
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@akashshinde can we please add some tests for these changes?
A Deployment is created in the
openshift-operators
@Avni-Sharma Can we deploy it in a different namespace?
@sbose78 How do you suggest to parameterize docker image path of topology service ?
A Deployment is created in the
openshift-operators
@Avni-Sharma Can we deploy it in a different namespace?
Let's create a new dedicated namespace for our service(s).
This PR borrows the work from https://github.com/redhat-developer/devconsole-operator/pull/195
A Deployment is created in the
openshift-operators
namespace such that the corresponding service would be reachable at devconsole-app.openshift-operators.svc:8080 Calls to this service would be proxied from the console backend [1] .To Do