search

redhat-developer / devconsole-operator

Enable a developer-focused view in OpenShift 4 web console
24 stars 28 forks source link

[WIP] Replace oc commands in OperatorSource automated test with client-go #213

Open pratikjagrut opened 5 years ago

pratikjagrut commented 5 years ago

This PR replaces the oc shell commands in OperatorSource automated test with client-go. Steps to run this test; make clean dep ensure -v make build make test-operator-source

Jira ticket

If you get any timeout error or panic error which may cause due slow connectivity between test machine and cluster, try increasing sleep time in test.mk->test-operator-source target then use following cleanup command oc delete sub devconsole -n openshift-operators | oc delete catsrc installed-custom-openshift-operators -n openshift-operators | oc delete csc installed-custom-openshift-operators -n openshift-marketplace | oc delete csv devconsole-operator.v0.1.0 -n openshift-operators and retry make test-operator-source.

Signed-off-by: Pratik Jagrut pjagrut@redhat.com

openshift-ci-robot commented 5 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: tinakurian

If they are not already assigned, you can assign the PR to them by writing /assign @tinakurian in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/devconsole-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 5 years ago

Hi @pratikjagrut. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
akashshinde commented 5 years ago

/ok-to-test

tinakurian commented 5 years ago

@pratikjagrut do you mind pasting a link to the jira ticket that this work is associated with in the description?

pratikjagrut commented 5 years ago

@pratikjagrut do you mind pasting a link to the jira ticket that this work is associated with in the description?

@tinakurian https://jira.coreos.com/browse/ODC-831

Avni-Sharma commented 5 years ago

can we have cleanup of resources as a separate PR/subtask if not in this PR?