search

redhat-developer / gitops-operator

An operator that gets you an ArgoCD for cluster configuration out-of-the-box on OpenShift along with the UI for visualizing environments.
Apache License 2.0
151 stars 282 forks source link

Fix Rollouts plugin location URL format (master branch) #734

Closed jgwest closed 4 months ago

jgwest commented 4 months ago

What type of PR is this? /kind bug

What does this PR do / why we need it:

When using pre-release builds, when you create an Argo Rollouts (install by creating a RolloutManager CR) the Rollouts Pod that is created will fail to start.

If you look at the Pods logs for the Rollout controller, you will see the following error:

[jgw@localhost-lan rollouts-plugin-trafficrouter-openshift]$ k logs pod/argo-rollouts-7bcddf67cf-hl8ph
time="2024-06-10T12:46:22Z" level=info msg="Argo Rollouts starting" version=vstable+737ca89
time="2024-06-10T12:46:22Z" level=info msg="Creating event broadcaster"
time="2024-06-10T12:46:22Z" level=info msg="Setting up event handlers"
time="2024-06-10T12:46:22Z" level=info msg="Setting up experiments event handlers"
time="2024-06-10T12:46:22Z" level=info msg="Setting up analysis event handlers"
time="2024-06-10T12:46:22Z" level=fatal msg="Failed to download plugins: plugin location must be of http(s) or file scheme"

The fix is a one line change to gitops-operator. The ConfigMap that is generated SHOUD contain this:

  trafficRouterPlugins: |
    - name: argoproj-labs/openshift
      location: file:/plugins/rollouts-trafficrouter-openshift/openshift-route-plugin
      sha256: ""
openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from jgwest. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/gitops-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jgwest commented 4 months ago

Red Hat Issue Tracker: https://issues.redhat.com/browse/GITOPS-4815

jgwest commented 4 months ago

/retest

cluster flake

jgwest commented 4 months ago

LGTM by Anand on the other PR