search

redhat-developer / gitops-operator

An operator that gets you an ArgoCD for cluster configuration out-of-the-box on OpenShift along with the UI for visualizing environments.
Apache License 2.0
147 stars 273 forks source link

Make the route API mandatory for the operator to successfully boot up #739

Closed anandf closed 1 month ago

anandf commented 2 months ago

What type of PR is this? /kind bug

What does this PR do / why we need it: Given a ROSA cluster with OpenShift GitOps installed, When ROSA hibernates and later resumes, the route API is not available immediately. But the operator pod is restarted and this causes the operator to be initialized without the Route API handling logic. Current workaround requires the operator pod to be restarted once the route api is available to fix the issue.

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #? https://issues.redhat.com/browse/GITOPS-4358

Test acceptance criteria:

How to test changes / Special notes to the reviewer:

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from anandf. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/gitops-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
varshab1210 commented 2 months ago

/test v4.14-images

openshift-ci[bot] commented 2 months ago

@anandf: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.13-images 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.13-images
ci/prow/v4.12-images 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.12-images
ci/prow/v4.13-e2e 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.13-e2e
ci/prow/v4.13-kuttl-sequential 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.13-kuttl-sequential
ci/prow/v4.13-kuttl-parallel 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.13-kuttl-parallel
ci/prow/v4.12-e2e 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.12-e2e
ci/prow/v4.12-kuttl-parallel 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.12-kuttl-parallel
ci/prow/v4.12-kuttl-sequential 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.12-kuttl-sequential
ci/prow/v4.14-e2e 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.14-e2e
ci/prow/v4.14-kuttl-parallel 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.14-kuttl-parallel
ci/prow/v4.14-kuttl-sequential 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.14-kuttl-sequential
ci/prow/v4.14-images 7146363027790abb44915ad57e212dc71812ff05 link true /test v4.14-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
svghadi commented 1 month ago

Superseded by #761