search

redhat-developer / gitops-operator

An operator that gets you an ArgoCD for cluster configuration out-of-the-box on OpenShift along with the UI for visualizing environments.
Apache License 2.0
147 stars 273 forks source link

ArgoCD won't update in the gitOps Operator and I need to mitigate CVE-2024-37152 ASAP #741

Open garyd2 opened 2 months ago

garyd2 commented 2 months ago

Describe the bug Running RedHat Openshift 4.15.17_1541

oc get csv -n openshift-operators
NAME                                DISPLAY                     VERSION   REPLACES                            PHASE
openshift-gitops-operator.v1.11.0   Red Hat OpenShift GitOps    1.11.0    openshift-gitops-operator.v1.10.1   Succeeded
oc get subscription -n openshift-operators
NAME                                                            PACKAGE                     SOURCE                CHANNEL
openshift-gitops-operator                                       openshift-gitops-operator   redhat-operators      latest

The Operator is stuck on 1.11.0 and wont update I have tried to edit the CRD for ArgoCD and enter a spec.version and spec.image and it pulled the image but the UI is still at v2.6.7+unknown

svghadi commented 2 months ago

v2.6.7 is quite old. GitOps 1.11.x ships with Argo CD 2.9.x version. I think there is some issue with operator. Can you check the .status field of your ArgoCD CR? if everything is in running state. Also worth checking the operator manager pod logs to see if there are any errors due to mis-configuration in ArgoCD CR.

garyd2 commented 2 months ago

Thanks @svghadi . I have found the issue.

This GitOps Operator does not play well at all if another Operator is having issues. I had an external secrets operator that was failing to update, (nothing to do with a GitOps Operator), when I fixed the external secrets operator then the GitOps operator kicked in and started to update - this is really really bad, imagine having 50 Operators running and 1 is bad, then GitOps will not work till every installed operator is working. This is a bug.

svghadi commented 2 months ago

Glad to hear that.

I will have to try to reproduce the issue to confirm, but I feel it is not related to the operator. The upgrades are handled by OLM, so it could be a bug there.