search

redhat-developer / henge

This project has merged into Kompose.
https://github.com/skippbox/kompose
MIT License
14 stars 7 forks source link

Update openshift #45

Closed kadel closed 8 years ago

kadel commented 8 years ago

After some Godeps.json hacking in OpenShift I was able to update Henge to latest OpenShift (11c7ed066aa65ec80dd34446f86bce9a285400f8)

kadel commented 8 years ago

this should depricate https://github.com/redhat-developer/henge/pull/18 because this fix should be already in OpenShift

surajssd commented 8 years ago

@kadel LGTM, #18 we still need to add code here https://github.com/redhat-developer/henge/pull/18/files#diff-0e84ec7c43751b982f29dbc4fa65927dR53

kadel commented 8 years ago

We are still using libcompose from openshift, so only thing that wee need to add are 3 lines to openshift/generate.go

if err := project.AddEnvironmentLookUp(context); err != nil {
   return nil, err
 }

is it right?

surajssd commented 8 years ago

@kadel yes true! And it will be in both kubernetes/generate.go and openshift/generate.go

kadel commented 8 years ago

great, I'm going to merge this than. Can you than please modify #18 so it only contains changes to oenshift/generate.go?

surajssd commented 8 years ago

@kadel sure!

kadel commented 8 years ago

thank you @surajssd