search

redhat-developer / henge

This project has merged into Kompose.
https://github.com/skippbox/kompose
MIT License
14 stars 7 forks source link

refactor parsing of commands, implement providers as subcommands, fix #43 #52

Closed concaf closed 8 years ago

concaf commented 8 years ago

@kadel @surajssd I have removed the requirement for pkg/transformers/main.go and created subcommands for openshift and kubernetes, so most of the things are being taken care of by cobra now.

Let me know what do you think of this approach so I can polish this and send the final PR.

Thanks.

surajssd commented 8 years ago

LGTM!

surajssd commented 8 years ago

@kadel once you LGTM, we can merge it!

kadel commented 8 years ago

Only one thing. If you do it like this than this part of code no longer executed: https://github.com/containscafeine/henge/blob/7d922b4047cf7a53ea5caa793c737ce2e997223c/henge.go#L20,L24

Or more exactly it is executed, but only after everything else, and only if there was no error before ;-)

surajssd commented 8 years ago

nice catch, i missed it somehow!

concaf commented 8 years ago

@surajssd @kadel, gotcha, thanks. How about now? Will squash once you guys LGTM!

kadel commented 8 years ago

:+1: LGTM We can squash it using magic merge button ;-)

concaf commented 8 years ago

@kadel @surajssd, squashed. Thanks :)

surajssd commented 8 years ago

cool, merging! Thanks @containscafeine !