search

redhat-developer / intellij-common

4 stars 11 forks source link

chore: add plugin verifier to github actions (#101) #106

Closed adietish closed 3 years ago

adietish commented 3 years ago

depends on #100 which needs to be merged first (runPluginVerifier only exists with intellij gradle plugin 1.1.4) fixes #101

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

jeffmaury commented 3 years ago

But noticed the verify job is failing, maybe because intellij-common is not a real plugin (ie no plugin.xml) so the verifyPlugin task fails

adietish commented 3 years ago

But noticed the verify job is failing, maybe because intellij-common is not a real plugin (ie no plugin.xml) so the verifyPlugin task fails

@jeffmaury: I was guessing the same. It's currently failing even though everthing looks ok. We'd drop this PR, agree?

adietish commented 3 years ago

WONT FIX since intellij-common is not a plugin but a lib. Closing.