search

redhat-developer / intellij-common

4 stars 11 forks source link

feat: add VfsRootAccesshelper for IntelliJ 2021.3 compatibility #123

Closed jeffmaury closed 2 years ago

jeffmaury commented 2 years ago

Fixes #122

Signed-off-by: Jeff MAURY jmaury@redhat.com

jeffmaury commented 2 years ago

Why is it inside the test folder? Shouldn't it be in main? This could be re-use somewhere else. Then the constructor is private but the method are not static.

This is only required during tests. Will fix the static issue

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

lstocchi commented 2 years ago

This is only required during tests. Will fix the static issue

We use that thing in other plugin tests so if you put it in common test is not visible outside... or is there a way to see that when importing IJ-common as dep?

jeffmaury commented 2 years ago

This is only required during tests. Will fix the static issue

We use that thing in other plugin tests so if you put it in common test is not visible outside... or is there a way to see that when importing IJ-common as dep?

No you can reuse them see https://github.com/redhat-developer/intellij-openshift-connector/blob/13654c4378efeae7445f9f5ab50ce80bf63b1b8f/build.gradle#L74