search

redhat-developer / intellij-common

4 stars 11 forks source link

feat: add silentMode to DownloadHelper (#121) #130

Closed lstocchi closed 2 years ago

lstocchi commented 2 years ago

it resolves #121

lstocchi commented 2 years ago

For better compatibility, I think the parameter should be part of the tool json file. Now I did not test your stuff but it looks to me that there will be still a dialog be shown and I think this should be hidden or a background task to make sure user does not cancel it.

What if we remove the cancel button from the progressindicator dialog? Atleast the user sees something. Because if we hide everything the user is not aware of what's happening and they see an empty view. If they have a slow connection they don't understand what's going on. Or we can go with a background task (i guess an indicator is shown on the bottom right side, no?) loadingcli

jeffmaury commented 2 years ago

TBH having something visible will always lead to user complaining. And user should see a Loading item in the tree, so it's my preference 👍

lstocchi commented 2 years ago

Now nothing is shown. Only a label (2 processes running in my case as knative is downloading kn and func clis) in the bottom right. If clicked all processes are displayed but not cancellable. background-2

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information