search

redhat-developer / intellij-common

4 stars 11 forks source link

Ignore kubeconfig changes where the config file is empty or deleted #191

Closed datho7561 closed 11 months ago

datho7561 commented 1 year ago

I'm not convinced this is doing much to address redhat-developer/intellij-kubernetes#640. In practice, the first few times I attempt to switch namespaces, the tree collapses, regardless of if I use this PR or the existing code. After that, I can occasionally switch namespaces without the tree collapsing.

See #190.

Signed-off-by: David Thompson davthomp@redhat.com

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

datho7561 commented 1 year ago

@adietish @olkornii

adietish commented 11 months ago

@datho7561 sorry, missed this one. Will look into it asap.

adietish commented 11 months ago

@datho7561 thanks a lot for filing this. I believe that the fixes that you provided here also are in #192. Unfortunately I missed yours when filing my fix. It would have spared me from doing the work you already did. Closing as DUPLICATE.