search

redhat-developer / intellij-common

4 stars 11 forks source link

ConfigWatcher does not notify if kubeconfig was deleted #201

Closed adietish closed 10 months ago

adietish commented 10 months ago

this follows up on #190

In #190 a check was introduced that would prevent multiple events from making it to the client program. Unfortunately this then caused - and we didn't notice it - removals of the kubeconfig not to be notified. Removing this check means that client programs now need to take care of the multiple events (for the same change) that #190 aimed at preventing.

adietish commented 10 months ago

@sbouchet: this PR makes sure that the config watcher would notify if the kubeconfig is removed and then offers the methods to compare a new kubeconfig with the old one, making sure things are null-safe (current impl in intellij-openshift isn't)