search

redhat-developer / intellij-common

4 stars 11 forks source link

feat: add system property to override download path #231

Closed sbouchet closed 1 month ago

sbouchet commented 2 months ago

fixes #229

adietish commented 1 month ago

@sbouchet: 2 tests are failing. Expected?

com.redhat.devtools.intellij.common.utils.DownloadHelperTest > testThatPlainFileDownloadedInUserSpecificFolder FAILED
    junit.framework.ComparisonFailure at DownloadHelperTest.java:88

com.redhat.devtools.intellij.common.utils.DownloadHelperTest > testThatChecksumIsInValidForDownloadedTool FAILED
    junit.framework.AssertionFailedError at DownloadHelperTest.java:78
sbouchet commented 1 month ago

@sbouchet: 2 tests are failing. Expected?

com.redhat.devtools.intellij.common.utils.DownloadHelperTest > testThatPlainFileDownloadedInUserSpecificFolder FAILED
    junit.framework.ComparisonFailure at DownloadHelperTest.java:88

com.redhat.devtools.intellij.common.utils.DownloadHelperTest > testThatChecksumIsInValidForDownloadedTool FAILED
    junit.framework.AssertionFailedError at DownloadHelperTest.java:78

no. investigating.

sbouchet commented 1 month ago

@adietish : looks better. need a way to customize path provided during test for windows

sbouchet commented 1 month ago

@adietish : please review now that tests are fixed, thanks !