search

redhat-developer / intellij-kubernetes

IntelliJ Kubernetes plugin
https://plugins.jetbrains.com/plugin/15921-kubernetes-by-red-hat
Eclipse Public License 2.0
20 stars 20 forks source link

use ActionPlaces.TOOLWINDOW_POPUP for resource tree popup menu (#705) #711

Closed adietish closed 10 months ago

adietish commented 10 months ago

fixes #705

adietish commented 10 months ago

@olkornii please review

sonarcloud[bot] commented 10 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

olkornii commented 10 months ago

Tested with: minikube v1.31.0, kubernetes v1.29.0 Intellij IDEA 2022.1 @adietish Hi, I've tried issue-705 branch. There is no Popup warning anymore. But I've noticed another warnings. Steps:

  1. open Kubernetes tab
  2. expand "Namespaces"
  3. right click on some namespace
  4. select "Use namespace"
  5. warning appears: 024-01-15 11:46:57,886 [ 69368] WARN - i.f.k.c.r.Readiness - Namespace is not a Readiable resource. It needs to be one of [Node, Deployment, ReplicaSet, StatefulSet, Pod, ReplicationController]
adietish commented 10 months ago

@olkornii: the warning that you noticed is not related. It is caused by the kubernetes client: https://github.com/fabric8io/kubernetes-client/issues/2672. It points us to bump the kubernetes-client at some point.