redhat-developer / intellij-openshift-connector

IntelliJ OpenShift Toolkit
https://plugins.jetbrains.com/plugin/12030-openshift-toolkit-by-red-hat/
Eclipse Public License 2.0
16 stars 23 forks source link

fix: fix name validation regexp #880

Closed sbouchet closed 1 month ago

sbouchet commented 4 months ago

What is the purpose of this change? What does it change?

Was the change discussed in an issue?

fixes #869

How to test changes?

sbouchet commented 3 months ago

actually, when using kubectl, it shows you the current regexp to use:

kubectl create namespace MY-namespace
The Namespace "MY-namespace" is invalid: metadata.name: Invalid value: "MY-namespace": a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name',  or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sbouchet commented 3 months ago

/override ci/prow/e2e-openshift

openshift-ci[bot] commented 3 months ago

@sbouchet: Overrode contexts on behalf of sbouchet: ci/prow/e2e-openshift

In response to [this](https://github.com/redhat-developer/intellij-openshift-connector/pull/880#issuecomment-2277368964): >/override ci/prow/e2e-openshift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
adietish commented 2 months ago

@sbouchet: build fails with missing intellij-common 1.9.6-SNAPSHOT. I thus bumped it to the final dependency: #911

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adietish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/intellij-openshift-connector/blob/main/OWNERS)~~ [adietish] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

New changes are detected. LGTM label has been removed.

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adietish commented 1 month ago

/override ci/prow/e2e-openshift

openshift-ci[bot] commented 1 month ago

@adietish: Overrode contexts on behalf of adietish: ci/prow/e2e-openshift

In response to [this](https://github.com/redhat-developer/intellij-openshift-connector/pull/880#issuecomment-2362032887): >/override ci/prow/e2e-openshift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.