search

redhat-developer / intellij-quarkus

IntelliJ Quarkus Tools
Eclipse Public License 2.0
120 stars 51 forks source link

Too many non-blocking read actions submitted at once in LSPDiagnosticHandler #1089

Closed mfortunat closed 1 year ago

mfortunat commented 1 year ago

Guys, the newly released version 1.24.0.508 has another, repeating, issue. IJ version is: "Build #IU-232.8660.185, built on July 26, 2023"

Stack trace:

java.lang.Throwable: Too many non-blocking read actions submitted at once. Please use coalesceBy, BoundedTaskExecutor or another way of limiting the number of concurrently running threads.: 11 with similar stack traces are currently active at com.intellij.openapi.diagnostic.Logger.error(Logger.java:370) at com.intellij.openapi.application.impl.SubmissionTracker.preventTooManySubmissions(SubmissionTracker.java:45) at com.intellij.openapi.application.impl.NonBlockingReadActionImpl$Submission.(NonBlockingReadActionImpl.java:272) at com.intellij.openapi.application.impl.NonBlockingReadActionImpl.submit(NonBlockingReadActionImpl.java:227) at com.redhat.devtools.intellij.lsp4ij.operations.diagnostics.LSPDiagnosticHandler.accept(LSPDiagnosticHandler.java:52) at com.redhat.devtools.intellij.lsp4ij.operations.diagnostics.LSPDiagnosticHandler.accept(LSPDiagnosticHandler.java:38) at com.redhat.devtools.intellij.lsp4ij.client.LanguageClientImpl.publishDiagnostics(LanguageClientImpl.java:68) at jdk.internal.reflect.GeneratedMethodAccessor291.invoke(Unknown Source) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.lambda$null$0(GenericEndpoint.java:65) at org.eclipse.lsp4j.jsonrpc.services.GenericEndpoint.notify(GenericEndpoint.java:152) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.handleNotification(RemoteEndpoint.java:220) at org.eclipse.lsp4j.jsonrpc.RemoteEndpoint.consume(RemoteEndpoint.java:187) at com.redhat.devtools.intellij.lsp4ij.LanguageServerWrapper.lambda$start$1(LanguageServerWrapper.java:334) at java.base/java.util.concurrent.CompletableFuture$AsyncRun.run(CompletableFuture.java:1804) at java.base/java.util.concurrent.CompletableFuture$AsyncRun.exec(CompletableFuture.java:1796) at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:373) at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1182) at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1655) at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1622) at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:165)

angelozerr commented 1 year ago

We use now non blocking read action to improve performance. Do you feel better performance?

@mfortunat we are indeed aware about this problem and we will try to fix it but it should not block the features of IJ Quarkus.

This error should come when there are too many validation for instance while IJ is indexing. Jav avalidation requires the PsiFile indexed and as it is not indexed it waits and and we have two meany read action.

Thanks for reporting this issue. We will work on it.

fbricon commented 1 year ago

can you describe how it happens? no user activity during startup, or are you trying to do things during startup? How big is your project (Nb files / Nb dependencies)

angelozerr commented 1 year ago

@mfortunat we have now a LSP console which track any messages (when validation should occur,completion etc).

Could you please activate trace as verbose:

image

And perhaps do the same thing for Qute language Server.

After that you shoud see LSP request/responses

image

When your problem occurs, could you share please your traces to see which services is too many called (I suspect it is the validation publish diagnostics)

Thanks!

angelozerr commented 1 year ago

After sen your trace::

t com.redhat.devtools.intellij.lsp4ij.operations.diagnostics.LSPDiagnosticHandler.accept(LSPDiagnosticHandler.java:52)
at com.redhat.devtools.intellij.lsp4ij.operations.diagnostics.LSPDiagnosticHandler.accept(LSPDiagnosticHandler.java:38)
at com.redhat.devtools.intellij.lsp4ij.client.LanguageClientImpl.publishDiagnostics(LanguageClientImpl.java:68)

It is the validation.

mfortunat commented 1 year ago

Hi @angelozerr, I enabled the verbose level tracing on both LSs. I'll put here any additional info I get from the new configuration.

mfortunat commented 1 year ago

Hi @fbricon, No special activities; just code editing. It happens quite soon after IJ restart. The project is a maven-based multi-module project with 5 modules. Quarkus is '2.15.1.Final', Lombok, Kafka, Redis and Oracle. Nothing particularly exotic

Hope this helps

fbricon commented 1 year ago

OK, so it's the initial indexing that's problematic. After that, quarkus tools should not get in your way

mfortunat commented 1 year ago

@angelozerr I noticed something weird; after more than 5 minutes, the 2 processes are still "starting"

Screen Shot 2023-08-09 at 5 44 18 pm
angelozerr commented 1 year ago

I noticed something weird; after more than 5 minutes, the 2 processes are still "starting"

Indeed that's very strange, I have never had this usecase, do you have the completion, validation features?

angelozerr commented 1 year ago

@mfortunat we have fixed the issue, now when a LSP request with the same parameter happens, it cancel the previous promise which should improve performance when you have a lot of validation for the same file and fix the " Too many non-blocking read actions submitted at once".

mfortunat commented 1 year ago

Hi @angelozerr and @fbricon, That's awesome! Thank you guys for fixing so quickly this annoying issue.

angelozerr commented 1 year ago

The CI build is down for the momeent but when it will be available again you can download a zip of the IJ Quarkus for each commit and test the fix, see https://github.com/redhat-developer/intellij-quarkus#testing-the-ci-builds

angelozerr commented 1 year ago

The project is a maven-based multi-module project with 5 modules.

To be honnest with you ,I have never tried with multi module, but by reading quickly the code I think we could have some trouble (perhaps your starting which never stopped comes deom multi module).

We need to work on https://github.com/redhat-developer/intellij-quarkus/issues/891

@mfortunat is there any chance that you share your quarkus project to have the context than you?

mfortunat commented 1 year ago

Hi @angelozerr,

Sorry, this is not an OSS project so I cannot share anything about it.

angelozerr commented 1 year ago

Id not possible to share your multi module project by removing java classes of your project just to share yhe structure of your project?

mfortunat commented 1 year ago

If I remove the classes, you won't be able to build it.

What I can say, however, is:

The logic behind it is a set of ETL microservices working together and each one dealing with a part of a complex ETL pipeline.

angelozerr commented 1 year ago

I noticed something weird; after more than 5 minutes, the 2 processes are still "starting"

@mfortunat I can confirm you that you have this issue because you have multi-modules which is totally bugged. We plan to create the release 1.27 today,but it will not fix multi-modules problems. It is my priority an dI have started something https://github.com/redhat-developer/intellij-quarkus/pull/1129 which will be available in 1.28 (we will create it as soon as 2 very annoying bugs https://github.com/redhat-developer/intellij-quarkus/pull/1129 and https://github.com/redhat-developer/intellij-quarkus/issues/1097#issuecomment-1710113115 will be fixed)