search

redhat-developer / intellij-quarkus

IntelliJ Quarkus Tools
Eclipse Public License 2.0
114 stars 43 forks source link

fix: add Java version selector to Quarkus wizard #1307

Closed fbricon closed 4 months ago

fbricon commented 4 months ago

Added new combo to select Java target version:

Screenshot 2024-01-17 at 15 52 05

The version is validated against the SDK previously selected:

Screenshot 2024-01-18 at 17 16 47

Fixes https://github.com/quarkusio/code.quarkus.io/issues/1266

Also improved general validation of that page for the other fields, to be more consistant with standard Intellij wizards:

Screenshot 2024-01-18 at 17 14 14

Finally, PR also fixes https://github.com/redhat-developer/intellij-quarkus/issues/79

angelozerr commented 4 months ago

It looks very good.

angelozerr commented 4 months ago

There are some label like quarkus.wizard.error.extensions.loading.message which uses QuarkusBundle, perhaps it could be a good idea to move hard coded string into this bundle?

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions

4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

angelozerr commented 4 months ago

Thanks so much @fbricon !