redhat-developer / intellij-tekton

IntelliJ Tekton plugin
https://plugins.jetbrains.com/plugin/14096-tekton-pipelines-by-red-hat
Eclipse Public License 2.0
20 stars 11 forks source link

feat: support authentication when pushing/fetching bundle (#609) #626

Closed lstocchi closed 1 year ago

lstocchi commented 1 year ago

it resolves #609

The gif below shows the authentication dialog that pop up. It didn't record my mouse pointer...... btw after i clicked on deploy, the loading cursor is enabled so the user see the plugin is doing something. A call is made to the registry if it answers with a 401 error (unauthorized) I show the authentication dialog which supports both username/password and token.

authenticationbundle

lstocchi commented 1 year ago

LGTM with the following remarks (unrelated to this PR but worth noting):

  • if image name contains protocol then an error is spawned when deploying
  • version has to be provided we should default it to latest

Opened a new issue to tackle your comment https://github.com/redhat-developer/intellij-tekton/issues/627