bigkevmcd commented 3 years ago

/kind enhancement What does this PR do / why we need it: A new Route is created during bootstrapping to make the default generated Nginx container available for testing.

Have you updated the necessary documentation?

[x] Documentation update is required by this PR.
[x] Documentation has been updated.

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

codecov-io commented 3 years ago

Codecov Report

Merging #156 (b0da176) into master (1848097) will increase coverage by 0.28%. The diff coverage is 81.81%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   59.04%   59.33%   +0.28%     
==========================================
  Files          55       56       +1     
  Lines        2813     2855      +42     
==========================================
+ Hits         1661     1694      +33     
- Misses        998     1003       +5     
- Partials      154      158       +4

Flag	Coverage Δ
unittests	`59.33% <81.81%> (+0.28%)`	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/pipelines/webhook/webhook.go	`14.47% <0.00%> (-0.20%)`	:arrow_down:
pkg/pipelines/bootstrap.go	`67.51% <76.47%> (-0.04%)`	:arrow_down:
pkg/pipelines/eventlisteners/routes.go	`86.66% <86.66%> (ø)`
pkg/pipelines/routes/routes.go	`86.20% <100.00%> (-0.46%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1848097...b0da176. Read the comment docs.

wtam2018 commented 3 years ago

/lgtm

wtam2018 commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

keithchong commented 3 years ago

Test considerations:

When you bootstrap a configuration. a new file 300-route.yaml is created in (for the taxi example):

environments/{prefix-}dev/apps/app-taxi/services/taxi/base/config

When you apply the resources and check ArgoCD, a new route resource is created for the service. Note that the service should be synchronized.

redhat-developer / kam

Create route for nginx #156

Codecov Report