search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Update argocd namespace to openshift-gitops #161

Closed chetan-rns closed 3 years ago

chetan-rns commented 3 years ago

What type of PR is this?

/kind enhancement

What does this PR do / why we need it: The GitOps operator creates an argocd instance in openshift-gitops namespace. This PR updates argocd namespace to openshift-gitops and removes the default argocd instance which gets created during bootstrap

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

chetan-rns commented 3 years ago

@amitkrout May need your help for updating the scripts to adopt this new change

amitkrout commented 3 years ago

@amitkrout May need your help for updating the scripts to adopt this new change

Curently CI is passing because the e2e test script - https://github.com/redhat-developer/kam/blob/master/test/e2e/features/basic.feature has not gone that far to report the operator installation failure in the wrong namespace argocd.

I fetched the pr and made changes accordingly in the operator and setup preparation script. make prepare-test-cluster reports failure while creating openshift-gitops namespace.

++ oc new-project openshift-gitops
Error from server (Forbidden): project.project.openshift.io "openshift-gitops" is forbidden: cannot request a project starting with "openshift-"

@chetan-rns Have you verified the day1 and day2 command manually with your changes ? if yes then @wtam2018 please review the pr and merge the pr after review comments are addressed.

We will track and fix operator and setup preparation script failure in another pr.

chetan-rns commented 3 years ago

@amitkrout openshift-gitops namespace will be created by the operator. Maybe we just have to create the OLM resources like we do for pipelines operator in the script.

chetan-rns commented 3 years ago

I tested it with bootstrap and all the argocd applications have openshift-gitops namespace. The argocd instance file is no longer generated since it's created by the operator

wtam2018 commented 3 years ago

/lgtm /approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment