search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Fix requirements section #168

Closed reginapizza closed 3 years ago

reginapizza commented 3 years ago

What type of PR is this? /kind documentation

What does this PR do / why we need it: -Corrected grammar -Added requirement for SSH keys connected to GitHub/GitLab and how to do that

Previously no mention of the need to have SSH key connected to GitHub/GitLab account to run kam bootstrap command

Have you updated the necessary documentation?

reginapizza commented 3 years ago

@wtam2018 if necessary I can make pages with steps for these in day1/prerequisites but the docs from GitHub/GitLab for these steps seemed sufficient.

wtam2018 commented 3 years ago

/lgtm /approve Thanks @reginapizza

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment