search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Address issue with multiple namespace files being created. #170

Closed bigkevmcd closed 3 years ago

bigkevmcd commented 3 years ago

What type of PR is this? /kind bug

What does this PR do / why we need it: When the internal registry is used, we generate more than one namespace file.

This causes issues in ArgoCD because there are duplicates of the same K8s object.

This ensures that the files have the same name, which means that whichever way they are created, they exist in the directory.

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment