search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

KAM to function without security manager #181

Closed keithchong closed 3 years ago

keithchong commented 3 years ago

Signed-off-by: Keith Chong kykchong@redhat.com

What type of PR is this?

/kind enhancement

What does this PR do / why we need it: For those cases where customers did not install the Sealed Secrets Operator, we need KAM to still work without generating sealed secrets. We will generate the unencrypted/unsealed secrets which can be secured separately.

Have you updated the necessary documentation?

Which issue(s) this PR fixes: See https://issues.redhat.com/browse/GITOPS-677

How to test changes / Special notes to the reviewer: Kevin wanted a new flag --insecure flag to give users the capability to force using unencrypted secrets and not by simply failing on the check that the sealed secrets operator is not installed.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign chetan-rns after the PR has been reviewed. You can assign the PR to them by writing /assign @chetan-rns in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 years ago

@keithchong: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
keithchong commented 3 years ago

@wtam2018, @chetan-rns, please do not review this yet, there is now a merge conflict.

openshift-ci[bot] commented 3 years ago

@keithchong: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.6-integration-e2e 415d5cd8faeeb429460a5003e08c5d23b5ccfde7 link /test v4.6-integration-e2e
ci/prow/unit 415d5cd8faeeb429460a5003e08c5d23b5ccfde7 link /test unit

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
keithchong commented 3 years ago

Closing this. See instead https://github.com/redhat-developer/kam/pull/185 for the rebased changes.