search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

[WIP] Add note about private repo workaround #197

Closed reginapizza closed 3 years ago

reginapizza commented 3 years ago

What type of PR is this? /kind documentation

What does this PR do / why we need it: Includes note about how to connect to a private git repo because currently there is some trouble doing so.

If necessary I can create and link to an actual doc in the repo but I figured that just linking to the docs in Argo CD was sufficient because they cover it very thoroughly.

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign amitkrout after the PR has been reviewed. You can assign the PR to them by writing /assign @amitkrout in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
reginapizza commented 3 years ago

Test aren't passing- I tried running go mod tidy and make cmd-docs but neither changed anything. Error says "go mod state is not clean"? Not sure what that means I need to do :/

@wtam2018 any ideas?

varshab1210 commented 3 years ago

pr https://github.com/redhat-developer/kam/pull/198 has been merged into master. @reginapizza would you please rebase your pr

chetan-rns commented 3 years ago

@reginapizza @wtam2018 Given that updating the CR doesn't work, should we even mention the approach in kam docs? We could directly point to the Argo CD docs page that explains configuring private repositories with CLI/UI. WDYT?

reginapizza commented 3 years ago

@chetan-rns so you mean basically get rid of this whole section and just point to the Argo CD docs? I'd be okay with that, my reasoning for not doing that is I wasn't sure if this would be getting fixed in the future and we would have to re-write it at some point.

chetan-rns commented 3 years ago

@reginapizza I've raised a PR to fix this. But I doubt it'll go with GitOps operator v1.1 https://github.com/argoproj-labs/argocd-operator/pull/269/files

reginapizza commented 3 years ago

@chetan-rns right, but in the meantime before that gets in shouldn't we be noting the workaround?

ishitasequeira commented 3 years ago

@reginapizza you could mention this work around for users who have their 2FA enabled

reginapizza commented 3 years ago

Just keeping this issue updated- This PR will not be needed if everything works as it's supposed to now that PR #95 of the gitops operator is merged. Will retest and re-evaluate if the fix works and if this is still needed.