redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Remove unnecessary CI variables #201

Closed varshab1210 closed 3 years ago

varshab1210 commented 3 years ago

What type of PR is this?

/kind cleanup

What does this PR do / why we need it:

Remove unnecessary CI variables

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #? N/A

How to test changes / Special notes to the reviewer:

CI job should pass

amitkrout commented 3 years ago

Awesome!!! Build artifacts are uploaded into artifacts directory. Earlier it was not showing because we were uploading it to some non-default path.

Screen Shot 2021-03-23 at 12 53 38 PM

/approve /lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [amitkrout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment