redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Disable --commit-status-tracker by default #203

Closed iam-veeramalla closed 3 years ago

iam-veeramalla commented 3 years ago

Signed-off-by: iam-veeramalla abhishek.veeramalla@gmail.com

/kind code-refactoring

What does this PR do / why we need it: Commit status tracker is an experiential project hosted in Tekton. Tekton will support this feature out of the box in future release. The current status of commit status tracker is not stable as it has not been kept up-to-date with Tekton APIs changes. We should hide user visible option to enable commit status tracker for the time being until we switch over to use the native support in Tekton (ref to ticket).

Fixes #? https://issues.redhat.com/browse/GITOPS-750

How to test changes / Special notes to the reviewer: Follow Day 1 operations to create a new gitops repo and webhook to trigger pipelines. After this change, you should not see the commit status on PR.

Work In Progress [Do not Merge]

varshab1210 commented 3 years ago
Run make cmd-docs
go run tools/cmd-docs/main.go
command-documentation is out of date (run make cmd-docs).

@iam-veeramalla Please run make cmd-docs, commit and push the changes.

varshab1210 commented 3 years ago

CI failure log details - https://github.com/redhat-developer/kam/pull/203/checks?check_run_id=2175474527#step:5:1

amitkrout commented 3 years ago

/approve /lgtm

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amitkrout

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [amitkrout] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment