search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Insecure option is not available in interactive mode (812) #219

Closed keithchong closed 3 years ago

keithchong commented 3 years ago

Signed-off-by: Keith Chong kykchong@redhat.com

What type of PR is this?

/kind enhancement We wanted to force users to specify --insecure from the command line because it is not a recommend option. But for consistency, we should add it in interactive mode. The message should be carefully worded to indicate it is not recommended.

What does this PR do / why we need it: Make --insecure option available in interactive mode

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

https://issues.redhat.com/browse/GITOPS-812

How to test changes / Special notes to the reviewer: See https://issues.redhat.com/browse/GITOPS-812 for scenarios and interactive mode examples.

iam-veeramalla commented 3 years ago

/lgtm /approve

iam-veeramalla commented 3 years ago

/approve cancel

iam-veeramalla commented 3 years ago

/lgtm /approve

chetan-rns commented 3 years ago

/approve

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns, iam-veeramalla

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [chetan-rns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment