redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Kam bootstrap --push-to-git flag #229

Closed amitkrout closed 3 years ago

amitkrout commented 3 years ago

What type of PR is this? /kind enhancement

What does this PR do / why we need it: Adding e2e test for --push-to-git flag

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #127

How to test changes / Special notes to the reviewer:

openshift-ci-robot commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from amitkrout after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
amitkrout commented 3 years ago
INFO[2021-04-26T13:55:48Z] Command stderr:  ✗  failed to create the gitops repository: "https://github.com/*******/taxi-229.git": failed to create repository, repo already exists

Will fix in consecutive commit /retest

amitkrout commented 3 years ago

/retest

amitkrout commented 3 years ago

/retest

amitkrout commented 3 years ago

/retest

amitkrout commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

@amitkrout: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/v4.7-integration-e2e f1ad5376c5683ac84028baa93c20071c533cdbf4 link /test v4.7-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
amitkrout commented 3 years ago

In the CI build process OpenShift (or is it container runtime? not sure) puts / as a home to /etc/passwd for the user the container runs for. Test platform tries to compensate by setting up a writable location and exporting it as $HOME which is fine for most cases but openssh does not respect $HOME and uses the item in /etc/passwd.

Screen Shot 2021-04-30 at 11 59 27 AM

In a conversation with platform team we guess a workaround might work but unfortunately it did not work

cc_ @petr-muller

I am closing this pr for now. When we will get a proper working documentation steps, i will open up a fresh pr to implement --push-to-git=true flag in CI

amitkrout commented 3 years ago

/close

openshift-ci-robot commented 3 years ago

@amitkrout: Closed this PR.

In response to [this](https://github.com/redhat-developer/kam/pull/229#issuecomment-829886838): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.