redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

doc: Update prerequisite: pipelines operator is no longer installed by gitops operator #242

Closed wtam2018 closed 3 years ago

wtam2018 commented 3 years ago

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring

What does this PR do / why we need it:

This PR updates the documentation where it talks about day1 prerequisite. GitOps operator no longer installs Pipelines Operator since v1.1.1

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer: Install GitOps operator on a fresh cluster and validate that Pipelines Operator is not installed automatically. As a result, day1 prerequisite explicitly instructs users to install the Pipelines Operator from OperatorHub.

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from wtam2018 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
dewan-ahmed commented 3 years ago

Screen Shot 2021-05-18 at 11 05 44 AM

There's a small typo in this file name (extra space before the extension). Rest of the PR looks good @wtam2018

chetan-rns commented 3 years ago

https://github.com/redhat-developer/kam/blob/0d30009bb8d2c18c3449c4b37da1a3edaa41aa55/pkg/cmd/bootstrap.go#L324

The bootstrap cmd asks users to install the GitOps operator if the pipelines operator is not found. We can now ask them to install the pipelines operator direclty

dewan-ahmed commented 3 years ago

/lgtm