redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Guidance how generated secrets can be stored as SealedSecrets (#943) #255

Closed keithchong closed 3 years ago

keithchong commented 3 years ago

Signed-off-by: Keith Chong kykchong@redhat.com

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes 943

How to test changes / Special notes to the reviewer: See screenshots in 943. Note that this change does not include removing the existing messages related to generating non-sealed secrets (using the --insecure flag). That should be part of 945. @ishitasequeira

keithchong commented 3 years ago

/retest

keithchong commented 3 years ago

/retest

chetan-rns commented 3 years ago

/retest

chetan-rns commented 3 years ago

/retest

keithchong commented 3 years ago

Hi @amitkrout , do you know why the 4.7 e2e test is failing? Looks like the 'argo-app' fails to be come synced.

wtam2018 commented 3 years ago

/retest

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chetan-rns commented 3 years ago

/test v4.7-integration-e2e

keithchong commented 3 years ago

/retest

amitkrout commented 3 years ago

/retest

ishitasequeira commented 3 years ago

/test v4.7-integration-e2e

amitkrout commented 3 years ago

/retest

amitkrout commented 3 years ago

/retest