redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

The add service command introduces backslashes in kustomize.yaml (#1212) #260

Closed keithchong closed 3 years ago

keithchong commented 3 years ago

Signed-off-by: Keith Chong kykchong@redhat.com

What type of PR is this?

/kind bug

What does this PR do / why we need it: Day 2 operations will be blocked. Users probably wouldn't know immediately that to fix it, they would have to edit and change all the backward slashes in the config\cicd\base\kustomize.yaml file by hand.

Before running kam service add, the paths in the file are of the form:

01-namespaces/cicd-environment.yaml

After running the command, kam incorrectly updates the file to include the OS specific file path and base folder prefix (which is why we don't see it on non-Windows platforms):

config\cicd\base\01-namespaces\cicd-environment.yaml

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes Jira 1212

How to test changes / Special notes to the reviewer: I've tested the changes on Windows, following the steps in Day 2 operations. Should be in for 1.2.

keithchong commented 3 years ago

/retest

keithchong commented 3 years ago

/retest

wtam2018 commented 3 years ago

/test v4.7-integration-e2e

wtam2018 commented 3 years ago

/lgtm /approve

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chetan-rns commented 3 years ago

/test v4.7-integration-e2e

chetan-rns commented 3 years ago

/test v4.7-integration-e2e