search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Replacing time.Sleep() with polling logic #284

Closed varshab1210 closed 3 years ago

varshab1210 commented 3 years ago

What type of PR is this?

/kind enhancement

What does this PR do / why we need it:

Currently test suite contains time.Sleep() which is not the appropriate way for implementing wait. This pr replaces time.Sleep() with polling logic

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

make e2e should pass

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

ishitasequeira commented 3 years ago

/test v4.8-integration-e2e

codecov-commenter commented 3 years ago

Codecov Report

Merging #284 (93ce6da) into master (8f50c1a) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #284   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files          57       57           
  Lines        2893     2893           
=======================================
  Hits         1695     1695           
  Misses       1031     1031           
  Partials      167      167
Flag Coverage Δ
unittests 58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8f50c1a...93ce6da. Read the comment docs.

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

varshab1210 commented 3 years ago

/test v4.8-integration-e2e

openshift-ci[bot] commented 3 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [chetan-rns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment