search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Drop custom Argo CD resources #294

Closed chetan-rns closed 10 months ago

chetan-rns commented 2 years ago

What type of PR is this?

/kind code-refactoring

What does this PR do / why we need it:

  1. Remove the locally maintained Argo CD operand and Application types
  2. Use the upstream Argo CD types
  3. Upgrade k8s deps

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from chetan-rns after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chetan-rns commented 2 years ago

/test v4.9-integration-e2e

varshab1210 commented 2 years ago

/test v4.9-integration-e2e

varshab1210 commented 2 years ago

/test v4.11-integration-e2e

openshift-ci[bot] commented 2 years ago

@chetan-rns: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chetan-rns commented 2 years ago

/test v4.11-integration-e2e

openshift-ci[bot] commented 1 year ago

@chetan-rns: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.12-integration-e2e 539e2048d9cb17159f68a83487a1f36d65065312 link true /test v4.12-integration-e2e
ci/prow/v4.11-integration-e2e 539e2048d9cb17159f68a83487a1f36d65065312 link true /test v4.11-integration-e2e
ci/prow/v4.13-integration-e2e 539e2048d9cb17159f68a83487a1f36d65065312 link true /test v4.13-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
varshab1210 commented 10 months ago

Closing this, please feel free to reopen if required