redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Release linux/ppc64le and linux/s390x binaries #311

Closed yselkowitz closed 2 years ago

yselkowitz commented 2 years ago

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind enhancement

What does this PR do / why we need it:

Adds linux/ppc64le and linux/s390x binaries to the release upload.

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

How to test changes / Special notes to the reviewer:

openshift-ci[bot] commented 2 years ago

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 2 years ago

Codecov Report

Merging #311 (9de8c45) into master (e975399) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files          57       57           
  Lines        2888     2888           
=======================================
  Hits         1692     1692           
  Misses       1030     1030           
  Partials      166      166           
Flag Coverage Δ
unittests 58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e975399...9de8c45. Read the comment docs.

wtam2018 commented 2 years ago

/ok-to-test

yselkowitz commented 2 years ago

/retest

yselkowitz commented 2 years ago

/retest

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [chetan-rns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
chetan-rns commented 2 years ago

/test v4.10-integration-e2e

yselkowitz commented 2 years ago

/retest

yselkowitz commented 2 years ago

/retest