Closed yselkowitz closed 2 years ago
Hi @yselkowitz. Thanks for your PR.
I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Merging #311 (9de8c45) into master (e975399) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 58.58% 58.58%
=======================================
Files 57 57
Lines 2888 2888
=======================================
Hits 1692 1692
Misses 1030 1030
Partials 166 166
Flag | Coverage Δ | |
---|---|---|
unittests | 58.58% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e975399...9de8c45. Read the comment docs.
/ok-to-test
/retest
/retest
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: chetan-rns
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test v4.10-integration-e2e
/retest
/retest
What type of PR is this?
/kind enhancement
What does this PR do / why we need it:
Adds linux/ppc64le and linux/s390x binaries to the release upload.
Have you updated the necessary documentation?
Which issue(s) this PR fixes:
How to test changes / Special notes to the reviewer: