search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Docs: Update docs for Deployment History (#2005) #313

Closed keithchong closed 2 years ago

keithchong commented 2 years ago

Signed-off-by: Keith Chong kykchong@redhat.com

What type of PR is this? /kind documentation

What does this PR do / why we need it: Deployment History is added so we should document it. Also the newly added Tabs make the existing screenshots out-of-date.

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

See https://issues.redhat.com/browse/GITOPS-2005

codecov-commenter commented 2 years ago

Codecov Report

Merging #313 (3036d58) into master (5820b00) will not change coverage. The diff coverage is n/a.

:exclamation: Current head 3036d58 differs from pull request most recent head a7131b5. Consider uploading reports for the commit a7131b5 to get more accurate results

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files          57       57           
  Lines        2888     2888           
=======================================
  Hits         1692     1692           
  Misses       1030     1030           
  Partials      166      166
Flag Coverage Δ
unittests 58.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5820b00...a7131b5. Read the comment docs.

keithchong commented 2 years ago

Hi @reginapizza and @chetan-rns , could you please review this? Thanks.

varshab1210 commented 2 years ago

/test v4.11-integration-e2e

chetan-rns commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chetan-rns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [chetan-rns] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ishitasequeira commented 2 years ago

/test v4.8-integration-e2e