search

redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

apply --dryrun no longer uses 'true' or 'false'. Instead it uses 'non… #325

Open jeffgus opened 2 years ago

jeffgus commented 2 years ago

…e', 'client', and 'server'.

What type of PR is this?

Uncomment only one /kind line, and delete the rest. For example, > /kind bug would simply become: /kind bug

/kind bug /kind cleanup /kind failing-test /kind enhancement /kind documentation /kind code-refactoring

What does this PR do / why we need it:

Have you updated the necessary documentation?

Which issue(s) this PR fixes:

Fixes #?

How to test changes / Special notes to the reviewer:

openshift-ci[bot] commented 2 years ago

Hi @jeffgus. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
chetan-rns commented 2 years ago

/ok-to-test

jeffgus commented 2 years ago

It is unclear to me why the bootstrap command would cause a failure. The code change is only changes what strings are written out to two files.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign wtam2018 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@jeffgus: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit a78f546c12f02005eedcb379ad1f759c44467e9e link true /test unit
ci/prow/v4.9-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.9-integration-e2e
ci/prow/v4.10-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.10-integration-e2e
ci/prow/v4.8-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.8-integration-e2e
ci/prow/v4.13-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.13-integration-e2e
ci/prow/v4.11-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.11-integration-e2e
ci/prow/v4.12-integration-e2e a78f546c12f02005eedcb379ad1f759c44467e9e link true /test v4.12-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).