redhat-developer / kam

GitOps Application Manager: An opinionated CLI that generates the Kubernetes resources for managing your Tekton-based CI manifests, ArgoCD-based CD manifests and Application manifests in Git.
Apache License 2.0
145 stars 83 forks source link

Fix go fmt with 1.19 #328

Closed yselkowitz closed 1 year ago

yselkowitz commented 1 year ago

What type of PR is this?

/kind failing-test

What does this PR do / why we need it:

Fixes go fmt errors with golang 1.19.z currently occurring in CI.

Have you updated the necessary documentation?

N/A

Which issue(s) this PR fixes:

How to test changes / Special notes to the reviewer:

The Validate PRs / Build (pull_request) github action should now pass.

openshift-ci[bot] commented 1 year ago

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
codecov-commenter commented 1 year ago

Codecov Report

Base: 58.58% // Head: 58.58% // No change to project coverage :thumbsup:

Coverage data is based on head (822af62) compared to base (92954ca). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #328 +/- ## ======================================= Coverage 58.58% 58.58% ======================================= Files 57 57 Lines 2888 2888 ======================================= Hits 1692 1692 Misses 1030 1030 Partials 166 166 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `58.58% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/redhat-developer/kam/pull/328?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer) | Coverage Δ | | |---|---|---| | [pkg/pipelines/accesstoken/accesstoken.go](https://codecov.io/gh/redhat-developer/kam/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy9hY2Nlc3N0b2tlbi9hY2Nlc3N0b2tlbi5nbw==) | `56.25% <ø> (ø)` | | | [pkg/pipelines/config/config.go](https://codecov.io/gh/redhat-developer/kam/pull/328/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer#diff-cGtnL3BpcGVsaW5lcy9jb25maWcvY29uZmlnLmdv) | `55.55% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=redhat-developer)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wtam2018 commented 1 year ago

/lgtm /approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wtam2018

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/redhat-developer/kam/blob/master/OWNERS)~~ [wtam2018] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wtam2018 commented 1 year ago

/ok-to-test

yselkowitz commented 1 year ago

/retest-required

varshab1210 commented 1 year ago

/retest-required

varshab1210 commented 1 year ago

/retest-required